AO3-4989 Deleting bookmark saves user bookmark filters#5625
Open
ReverM wants to merge 5 commits intootwcode:masterfrom
Open
AO3-4989 Deleting bookmark saves user bookmark filters#5625ReverM wants to merge 5 commits intootwcode:masterfrom
ReverM wants to merge 5 commits intootwcode:masterfrom
Conversation
ReverM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-4989
Purpose
This makes it so that deleting bookmark from the user page does keep the filtering, when using javascript. Behaviour from the general bookmark page stays unchanged
Testing Instructions
See jira comment
Credit
Danaël / Rever ( they / he )
Danaël Villeneuve on jira