AO3-6520 Use higher contrast visited link hover color in Reversi

[RhymeTheRapper]

Pull Request Checklist

• [X ] Have you read "How to write the perfect pull request"?
• [X ] Have you read the contributing guidelines?
• [ X] Have you added tests for any changed functionality?
• [ X] Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• [ X] Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6520

Purpose

Already visited links are dark gray on hover in the Reversi skin which is low contrast. The Jira issue was for work links but this affects most visited links on the site. I changed the hover color to be the same blue that unvisited links are. There are a few ways that this issue could be fixed but I figured this was the easiest and most straightforward. This does affect links in paragraphs like the about section (shown below), which were previously white. Further specificity can be added for these links if the hover to white is preferred.

Also moved the tag:hover and some footer styles below the a:visited:hover list. This is because the tag:hover needs to be below a:visited:hover in order to have the color for the text properly set. Otherwise the blue color takes priority in CSS stylesheet rules. These lists do not share style specificities so there should not be an issue in rearranging them.

Testing Instructions

See instructions in Jira issue. This affects any previously visited links and the li for work categories on the home page.

Credit

Rhyme Dochtermann She/Her

[Bilka2]

Hi, Rhyme Dochtermann!

Thank you so much for this pull request. Someone will be along to review it soon.

I've updated the Jira issue status to In Review so no one mistakenly opens a duplicate pull request. If you'd like the ability to comment on, assign, and transition issues in the future, you're welcome to create a Jira account! It makes things a bit easier for us on the organizational side if the Full Name on your Jira account either closely matches the name you'd like us to credit in the release notes or includes it in parentheses, e.g. "Nickname (CREDIT NAME)."

Once you've done that (or if you've already done it -- Jira has been unreliable about showing us new accounts in the admin panel lately), you can either reply here or send an email to otw-coders@transformativeworks.org with your account name and email address and we'll set up the permissions for you.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

[sarken]

Thanks for working on this!

In the Default skin, the hover color for visited links is #111, which matches unvisited links and is slightly higher contrast than our default text color (#2a2a2a). Because of that, I think it would be more consistent to use #fff as our color in Reversi. It also gives us a bit more contrast with the background than the blue.

Would adding a:not(.tag):visited:hover here work without unwanted side effects?

otwarchive/public/stylesheets/masters/reversi/reversi_site_screen_.css

Lines 236 to 253 in a1c810a

	a,
	a:link,
	a.tag,
	#header a,
	#header a:visited,
	#header .primary .open a,
	#header .primary .dropdown:hover a,
	#header .primary .dropdown a:focus,
	#header #search input:focus,
	#header #search input:hover,
	#dashboard a,
	#dashboard span,
	#dashboard .current,
	.heading,
	.group .heading,
	.filters dt a:hover {
	color: #fff;
	}