AO3-6218 Allow certain admins to access all collection and challenge pages usually reserved for owners #5592
Annotations
1 error and 9 warnings
|
rubocop
Process completed with exit code 1.
|
|
rubocop:
app/controllers/challenge_signups_controller.rb#L104
[rubocop] reported by reviewdog 🐶
Use 2 (not 4) spaces for indentation.
Raw Output:
app/controllers/challenge_signups_controller.rb:104:7: C: Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
|
|
rubocop:
app/controllers/challenge_signups_controller.rb#L49
[rubocop] reported by reviewdog 🐶
Don't use parentheses around the condition of an `unless`.
Raw Output:
app/controllers/challenge_signups_controller.rb:49:48: C: Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an `unless`.
|
|
rubocop:
app/controllers/challenge_requests_controller.rb#L16
[rubocop] reported by reviewdog 🐶
Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
Raw Output:
app/controllers/challenge_requests_controller.rb:16:26: C: I18n/DeprecatedHelper: Prefer Rails built-in `t` helper over `ts` and move the text into the yml file. `ts` is not actually translatable. For more information, refer to https://github.com/otwcode/otwarchive/wiki/Internationalization-(i18n)-Standards
|
|
rubocop:
app/controllers/challenge_claims_controller.rb#L72
[rubocop] reported by reviewdog 🐶
Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`.
Raw Output:
app/controllers/challenge_claims_controller.rb:72:5: C: Style/IfUnlessModifier: Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`.
|
|
rubocop:
app/controllers/challenge_claims_controller.rb#L2
[rubocop] reported by reviewdog 🐶
Extra empty line detected at class body beginning.
Raw Output:
app/controllers/challenge_claims_controller.rb:2:1: C: Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.
|
|
rubocop:
app/controllers/challenge/prompt_meme_controller.rb#L2
[rubocop] reported by reviewdog 🐶
Extra empty line detected at class body beginning.
Raw Output:
app/controllers/challenge/prompt_meme_controller.rb:2:1: C: Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.
|
|
rubocop:
app/controllers/challenge/gift_exchange_controller.rb#L2
[rubocop] reported by reviewdog 🐶
Extra empty line detected at class body beginning.
Raw Output:
app/controllers/challenge/gift_exchange_controller.rb:2:1: C: Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.
|
|
rubocop:
app/controllers/application_controller.rb#L364
[rubocop] reported by reviewdog 🐶
Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Raw Output:
app/controllers/application_controller.rb:364:5: W: Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
|
|
rubocop:
app/controllers/application_controller.rb#L354
[rubocop] reported by reviewdog 🐶
Wrap expressions with varying precedence with parentheses to avoid ambiguity.
Raw Output:
app/controllers/application_controller.rb:354:5: W: Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity.
|
Loading