AO3-7140 Changed view of Assignment to be less confusing#5541
Open
ReverM wants to merge 7 commits intootwcode:masterfrom
Open
AO3-7140 Changed view of Assignment to be less confusing#5541ReverM wants to merge 7 commits intootwcode:masterfrom
ReverM wants to merge 7 commits intootwcode:masterfrom
Conversation
ReverM
commented
Jan 30, 2026
marcus8448
suggested changes
Mar 21, 2026
Member
marcus8448
left a comment
marcus8448
left a comment
There was a problem hiding this comment.
Just a couple wording + translation bits.
Could you add a test for the display of the created_at date for drafts?
| <%= t(".stats.status.unposted") %> | ||
| <% elsif !assignment.fulfilled? %> | ||
| <strong><%= ts("Unapproved") %><!-- BACK END add approve button for mod --></strong> | ||
| <strong><%= t(".stats.status.unfullfilled") %><!-- BACK END add approve button for mod --></strong> |
Member
There was a problem hiding this comment.
Suggested change
| <strong><%= t(".stats.status.unfullfilled") %><!-- BACK END add approve button for mod --></strong> | |
| <strong><%= t(".stats.status.unfulfilled") %><!-- BACK END add approve button for mod --></strong> |
Could also be unapproved to match the displayed text.
(same typo for fulfilled)
| Then I should see "My Assignments" | ||
| And I should not see "Awesome Gift Exchange" | ||
|
|
||
| Scenario: Information regarding the status of an assignment is not confusing (AO3-7140) |
Member
There was a problem hiding this comment.
It's hard to tell what's being tested from the scenario name.
Maybe something like displaying the draft status [and using the creation date] for unposted works? (then the issue number can be omitted as well)
| fandom: Fandom %{allowed_fandom_count} | ||
| challenge_assignments: | ||
| assignment_blurb: | ||
| header_draft: "%{link} (draft)" |
Member
There was a problem hiding this comment.
Could you change the variable name to title_link or similar?
| <% if !assignment.posted? %> | ||
| <%= t(".header_draft", link: (link_to (assignment.creation.try(:title) || assignment.creation.class.name), assignment.creation, class: "work")) %> | ||
| <% else %> | ||
| <%= t(".header_posted", link: (link_to (assignment.creation.try(:title) || assignment.creation.class.name), assignment.creation, class: "work")) %> |
Member
There was a problem hiding this comment.
The title link can just be inserted directly here (no need for a translation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-7140
Purpose
This changes how the assignment blurb look when you have a drafted work that is unposted (changing Posted to Created and adding (draft) to the title)
Credit
Danaël / Rever ( they / he )
Danaël Villeneuve on Jira