AO3-3245 Manually entering the post link for a closed collection gives a misleading error #5504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilka2
changed the title
marcus8448
suggested changes
Dec 20, 2025
Contributor
marcus8448
left a comment
marcus8448
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| @unposted = current_user.unposted_work | ||
|
|
||
| # Check if collection is closed and user doesn't have permission to post | ||
| if @collection&.closed? && !@collection&.user_is_owner?(current_user) && !@collection&.user_is_maintainer?(current_user) |
Contributor
There was a problem hiding this comment.
user_is_maintainer? should already include all owners.
| edit_tags: | ||
| page_title: Edit Work Tags | ||
| new: | ||
| closed_collection_error: Sorry, the collection %{collection_title} is closed, new works cannot be added to it. |
Contributor
There was a problem hiding this comment.
I think we prefer to not have an _error suffix on translation keys.
Suggested change
| closed_collection_error: Sorry, the collection %{collection_title} is closed, new works cannot be added to it. | |
| closed_collection: Sorry, the collection %{collection_title} is closed. New works cannot be added to it. |
| include LoginMacros | ||
| include RedirectExpectationHelper | ||
|
|
||
| describe "GET #new" do |
Contributor
There was a problem hiding this comment.
The work spec is split across multiple files, so these tests should join the rest of the new tests in default_rails_actions_spec.rb:
|
|
||
| before do | ||
| fake_login_known_user(user) | ||
| collection.collection_participants.create(pseud: user.default_pseud, participant_role: CollectionParticipant::OWNER) |
Contributor
There was a problem hiding this comment.
It would be a bit nicer to create the participant in a let statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-3245 (Please fill in issue number and remove this comment.)
Purpose
Adds a check in the Works Controller to make sure a Collection isn't closed. If it is, and the User is not Owner or Moderator, it redirects them back to the collection index page with a message.
Credit
Scott (he/him)