AO3-7206 Chapter title, summary and notes missing in downloads of multichapter works with 1 chapter #5495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered? I assume the elseif is there for a reason
Contributor
Author
|
I looked at Quen's change and we basically did the same thing but I kept the elseif. I assume it was there for a reason since the if statement was originally a > 1 check. |
Contributor
Author
|
I am unsure of the purpose of that test. Since having a draft chapter 2 then deleting chapter 1 is impossible, I don't know if we should just remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7206
Purpose
This allow users to download multi-chapter works with one chapter (eg. 1/?) with chapter title and notes correctly included.
Credit
Jennifer He (DisappearEagle 无鸢）