AO3-7143 Adding filter to user collection page

[ReverM]

Issue

https://otwarchive.atlassian.net/browse/AO3-7143

Purpose

This adds the ability to filter collections on user pages like on the generic collections page.

Credit

Danaël / Rever (they / he)

[ReverM]

To note, I am currently working on implementing cucumber tests to test this feature, but I ran into a pickle (pun intended) while doing so. The feature is complete currently, but if you would prefer if there are unit tests for this feature, I shall work on them promptly.

[anmazz]

To note, I am currently working on implementing cucumber tests to test this feature, but I ran into a pickle (pun intended) while doing so. The feature is complete currently, but if you would prefer if there are unit tests for this feature, I shall work on them promptly.

(I'm not an official volunteer, so please defer to them if they disagree with me!)

Yes, from what I've seen volunteers want to see cucumber and/or rpsec tests for functionality changes, so I would definitely implement those here. Automated testing is in the Pull Request Checklist when you open a PR, more about it here on the wiki: https://github.com/otwcode/otwarchive/wiki/Automated-Testing.

You're probably already on it, but also make sure you're passing the Rubocop and ERB Linting checks. Unfortunately touching some older lines of code will often cause these checks to fail, but good news is you just need to fix the added/changed lines and not the whole file. (if you happen to be using VSCode as your IDE, I personally use the Ruby LSP extension by Shopify and it's really good at pointing out the Rubocop issues - just throwing that out there in case you used VSCode).

[ReverM]

As per https://github.com/otwcode/otwarchive/wiki/Reviewdog-and-RuboCop the RuboCop errors regarding regex seem to be normal. Am I to be doing anything with that regard?

Let me know if more tests are needed as well