-
Notifications
You must be signed in to change notification settings - Fork 650
AO3-7119 Use standard analyzer for tags on bookmark search #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
(Not an official volunteer, so please defer to them if they disagree with me!) I’d recommend adding a Cucumber |
| tag: { | ||
| type: "text", | ||
| analyzer: "simple" | ||
| analyzer: "standard" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be able to remove this line, the standard analyzer should be the default, but I would wait until an official volunteer confirms before removing. Looking through the code there are some explicit instances of analyzer: "standard", so might be totally fine as is!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll wait until there's confirmation. Thanks for reviewing my PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine to keep explicit. Generally, I would say that we have no set style preference for this situation.
Personally, I like when a decision like this has an easy to follow git blame for why it is the way it is, so keeping this line makes it easier to git blame -> find this pr -> find the related test and jira issue
Bilka2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
No problem, thanks for reviewing! |
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7119
Purpose
This PR fixes a bookmark indexing issue by changing the Elasticsearch bookmark analyzer from simple to standard.
Credit
Cubostar, he/him