-
Notifications
You must be signed in to change notification settings - Fork 11
OD-1836 Convert Automated Archive output to working schema #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ariana-paris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments but some may be because my Python is getting rusty or I'm misreading things!
| _extract_date(args, FILES[i], log), | ||
| FILES[i].get("Location", "").replace("'", "\\'"), | ||
| FILES[i] | ||
| .get("LocationURL", FILES[i].get("StoryURL", "")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why these lines weren't indented, or is that a Python thing I've forgotten?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the items in this array have the same indentation, though it is kinda confusing that the ruff formatter broke up certain lines but not others (like the Location line vs the LocationURL line). So it may look odd but it is fine, unless you're talking about something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just about it looking odd and more difficult for a human to interpret since continuation lines are usually indented relative to their first line. However, this file isn't a high priority so if ruff is going to be run on the whole repo, we'll have to let it do its thing to avoid noisy diffs!
per Ariana's suggestion Co-authored-by: Ariana <ariana-paris@users.noreply.github.com>
There are a few changes here so that ODAP can process an Automated Archive like Unit B, and also that the end result is the same working schema that is the output of the eFiction repo so it can be fed into steps 3-6.
Conversion to working schema changes
Changes due to issues processing Unit B
Other