-
Notifications
You must be signed in to change notification settings - Fork 0
docs: update model creation instructions with link to model artifacts #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ZhangEnYao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the clarity and navigability of the model creation documentation. It introduces a direct link within the model creation steps to the dedicated section for model artifacts, ensuring users can quickly access related information without manual searching. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve the documentation by adding a link to the model artifacts page within the model creation instructions. This is a useful change, but the provided link URL is incorrect. The documentation framework, Astro Starlight, removes numerical prefixes from filenames when generating URLs, which will cause the link to be broken. I've included a review comment with a suggested fix to correct the path.
| <Steps> | ||
| 1. Select **Create** from the actions menu or click the **Create** button. | ||
| 2. You can search for models using the cloud icon next to the input box, or select a model from your model artifacts by clicking the archive icon. | ||
| 2. You can search for models using the cloud icon next to the input box, or select a model from your [model artifacts](/service/settings/05-model-artifact/) by clicking the archive icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL for the 'model artifacts' link is incorrect. The documentation framework being used (Astro Starlight) automatically removes numerical prefixes like '05-' from filenames when creating page URLs. As a result, the link will be broken. To fix this, the '05-' prefix should be removed from the URL path.
2. You can search for models using the cloud icon next to the input box, or select a model from your [model artifacts](/service/settings/model-artifact/) by clicking the archive icon.
No description provided.