Skip to content

Remove init from Protocol Interface #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
otaviocc merged 2 commits into from
Nov 23, 2025
Merged

Remove init from Protocol Interface #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
762f82b
Remove init from Protocol Interface
otaviocc Oct 15, 2025
2f70246
Merge branch 'main' into feature/improvements
otaviocc Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Sources/MicroClient/NetworkClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
/// The network client interface.
public protocol NetworkClientProtocol: Sendable {

/// Initializes the client with a given configuration.
/// - Parameter configuration: The client configuration.
init(
configuration: NetworkConfiguration
)

/// Performs the network request.
///
/// - Parameter networkRequest: The network request to perform.
Expand Down Expand Up @@ -56,7 +50,7 @@

// swiftlint:disable function_body_length

private func performRequest<ResponseModel>(

Check warning on line 53 in Sources/MicroClient/NetworkClient.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)
_ networkRequest: NetworkRequest<some Any, ResponseModel>,
attempt: Int
) async throws -> NetworkResponse<ResponseModel> {
Expand Down Expand Up @@ -106,7 +100,7 @@
}

if let httpResponse = response as? HTTPURLResponse {
log(.info, "Response: \(httpResponse.statusCode) \(urlRequest.httpMethod ?? "") \(urlRequest.url?.absoluteString ?? "")")

Check warning on line 103 in Sources/MicroClient/NetworkClient.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Line should be 120 characters or less; currently it has 133 characters (line_length)
log(.debug, "Response headers: \(httpResponse.allHeaderFields)")

guard (200...299).contains(httpResponse.statusCode) else {
Expand Down