Fix #232: updated Help and Quiz modals to scale properly with internal scrolling#332
Open
shubh0284 wants to merge 2 commits into
Open
Fix #232: updated Help and Quiz modals to scale properly with internal scrolling#332shubh0284 wants to merge 2 commits into
shubh0284 wants to merge 2 commits into
Conversation
leandrumartin
requested changes
Apr 9, 2026
Collaborator
leandrumartin
left a comment
leandrumartin
left a comment
There was a problem hiding this comment.
The result looks good when I run the code and view the site. But there are also a lot of other changes in here to things like spacing and comments that aren't immediately relevant—it looks like it might be from an automatic linter. I'm wary of merging this because it this many changed lines could lead to merge conflicts in the future. Can you cut this down to just the essential changes required to resolve the issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #232
This PR addresses the issue where the Help and Quiz modals were exceeding the viewport height on smaller screens, making the close button inaccessible.
What does it add?
Why is it necessary?
To ensure the application is accessible on mobile devices and smaller browser windows as per the project's goal.
How was it tested?
Tested locally by resizing the browser window to various aspect ratios and confirming that the "Close Guide" button remains visible and the text is scrollable.
PR Checklist