Conversation
Added a step to install dependencies for the build process.
Removed installation of specific versions of gcc and g++.
directionless
previously approved these changes
Jan 16, 2026
| branches: [ "master" ] | ||
| tags: [ "*" ] | ||
| pull_request: | ||
| branches: [ "master" ] |
Member
There was a problem hiding this comment.
Suggested change
| branches: [ "master" ] | |
| branches: [ "master", "main"] |
We should rename this to main while you're tinkering
Member
Author
There was a problem hiding this comment.
I'd prefer to address that separately, and through all the osquery repos when we do it.
Member
There was a problem hiding this comment.
reasonable, though I'd still include main here, since then this job will be ready. (And it seems unlikely to be an issue)
| if [[ "${GITHUB_REF_TYPE}" == "tag" ]]; then | ||
| echo "VERSION=${GITHUB_REF_NAME}-$(uname -m)" >> "$GITHUB_ENV" | ||
| else | ||
| echo "VERSION=${GITHUB_SHA}-$(uname -m)" >> "$GITHUB_ENV" |
Member
There was a problem hiding this comment.
This seems fine, but will also be a lot harder to understand than git describe --tags --always --dirty
Actually... I think you can ditch the if statement and just use that directly.
directionless
previously approved these changes
Jan 31, 2026
Member
Author
|
@directionless I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.