Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds URL parameter support for favorite folders, allowing users to share and navigate to specific folders via URL. The implementation synchronizes the URL with the currently open folder and handles browser back/forward navigation.
Changes:
- Modified
useUpdateQueryParamhook to return an object containing bothupdateQueryParamfunction andsearchParams, improving API consistency and allowing consumers to access search parameters directly - Added URL synchronization for favorite folders using a
folderquery parameter that tracks the currently open folder - Implemented map marker filtering to show only the open folder's markers when a folder is selected, improving map clarity
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
map/src/util/hooks/menu/useUpdateQueryParam.js |
Changed return value from function to object containing updateQueryParam and searchParams |
map/src/menu/weather/WeatherForecastSourceActions.jsx |
Updated to destructure updateQueryParam from hook return value |
map/src/menu/weather/WeatherForecastDetails.jsx |
Updated to destructure updateQueryParam from hook return value |
map/src/frame/components/header/HeaderMenu.jsx |
Updated to destructure updateQueryParam from hook return value |
map/src/menu/favorite/FavoritesMenu.jsx |
Added URL synchronization logic, back/forward navigation handling, and loading state for folder opening |
map/src/menu/favorite/FavoriteGroup.jsx |
Added URL parameter update when folders are opened |
map/src/menu/actions/GroupHeader.jsx |
Added URL parameter updates when folders are closed via back button or close button |
map/src/menu/MainMenu.js |
Added check to prevent navigation when folder URL parameter exists during favorites loading |
map/src/map/layers/FavoriteLayer.js |
Refactored marker visibility logic to show only open folder's markers when a folder is selected |
map/src/context/AppContext.js |
Added FAVORITES_URL_PARAM_FOLDER constant for the folder query parameter name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RZR-UA
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.