Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Removed support for file system credentials caching.
* S3 download URLs are now validated.
* Improved request timeout handling.

## 4.0.0 - 2026-01-22

Expand Down
2 changes: 1 addition & 1 deletion okdata/sdk/auth/credentials/password_grant.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ def refresh_token(self, refresh_token):

def new_token(self):
payload = {"username": self.username, "password": self.password}
response = requests.post(url=self.token_service_url, json=payload)
response = requests.post(url=self.token_service_url, json=payload, timeout=10)
return response.json()
2 changes: 1 addition & 1 deletion okdata/sdk/data/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def download(self, dataset_id, version, edition, output_path, retries=0):
if not file_url.startswith(base_url):
raise DownloadURLAssertionError(file_url, base_url)

file_content_response = requests.get(file_url, stream=True)
file_content_response = requests.get(file_url, stream=True, timeout=10)
file_content_response.raise_for_status()

write_file_content(file_name, output_path, file_content_response.raw.read())
Expand Down
10 changes: 9 additions & 1 deletion okdata/sdk/sdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@
log = logging.getLogger()


class TimeoutHTTPAdapter(HTTPAdapter):
"""HTTP adapter with a default timeout."""

def send(self, request, *args, **kwargs):
kwargs["timeout"] = 10 # Defualt timeout (seconds)
return super().send(request, *args, **kwargs)


class SDK:
def __init__(self, config=None, auth=None, env=None):
self.config = config
Expand Down Expand Up @@ -72,7 +80,7 @@ def prepared_request_with_retries(retries):
"TRACE",
],
)
adapter = HTTPAdapter(max_retries=retry_strategy)
adapter = TimeoutHTTPAdapter(max_retries=retry_strategy)
session = requests.Session()
session.mount("https://", adapter)
session.mount("http://", adapter)
Expand Down
Loading