Conversation
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 3 | 0 | 0 | 0.04s | |
| ✅ JSON | jsonlint | 4 | 0 | 0 | 0.12s | |
| ✅ JSON | prettier | 4 | 0 | 0 | 0.59s | |
| ✅ JSON | v8r | 4 | 0 | 0 | 7.24s | |
| markdownlint | 155 | 4 | 0 | 2.35s | ||
| markdown-table-formatter | 155 | 1 | 0 | 0.46s | ||
| ✅ REPOSITORY | checkov | yes | no | no | 18.35s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.04s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 1.72s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 5.05s | |
| ✅ SPELL | codespell | 163 | 0 | 0 | 0.58s | |
| ✅ SPELL | lychee | 163 | 0 | 0 | 44.5s | |
| ✅ YAML | prettier | 4 | 0 | 0 | 0.44s | |
| ✅ YAML | v8r | 4 | 0 | 0 | 6.99s | |
| ✅ YAML | yamllint | 4 | 0 | 0 | 0.48s |
Detailed Issues
⚠️ MARKDOWN / markdown-table-formatter - 1 error
1 files contain markdown tables to format:
- docs/guides/migration-guide/cephadm/index.md
⚠️ MARKDOWN / markdownlint - 4 errors
docs/guides/migration-guide/cephadm/index.md:99:69 error MD060/table-column-style Table column style [Table pipe does not align with header for style "aligned"]
docs/guides/migration-guide/cephadm/index.md:100:69 error MD060/table-column-style Table column style [Table pipe does not align with header for style "aligned"]
docs/guides/migration-guide/cephadm/index.md:101:69 error MD060/table-column-style Table column style [Table pipe does not align with header for style "aligned"]
docs/guides/migration-guide/cephadm/index.md:327 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_SECRETLINT,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,SPELL_CODESPELL,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Show us your support by starring ⭐ the repository
berendt
force-pushed
the
cephadm
branch
3 times, most recently
from
99f0866 to
5a08a58
Compare
AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
jklare
requested changes
Apr 2, 2026
Contributor
jklare
left a comment
jklare
left a comment
There was a problem hiding this comment.
some comments, thoughts and questions
Comment on lines
+386
to
+391
| Ensure that the daemon is still running under the legacy systemd unit before attempting | ||
| adoption. Check with: | ||
|
|
||
| ```bash | ||
| sudo systemctl status ceph-<type>@<id> | ||
| ``` |
Contributor
There was a problem hiding this comment.
what is the expected outpt and how does the wrong one look like?
Comment on lines
+395
to
+401
| Verify that the node can reach the container registry. For OSISM environments: | ||
|
|
||
| ```bash | ||
| sudo cephadm pull registry.osism.tech/osism/ceph-daemon:${CEPH_RELEASE} | ||
| ``` | ||
|
|
||
| If the node is behind a proxy, ensure the container runtime is configured to use it. |
Contributor
There was a problem hiding this comment.
how does an example error look like?
jklare
requested changes
Apr 2, 2026
Comment on lines
+379
to
+383
| Wait until the new RGW daemons are running: | ||
|
|
||
| ```bash | ||
| ceph orch ps --daemon-type rgw | ||
| ``` |
Contributor
There was a problem hiding this comment.
what is the expected output here?
- Add known limitations info box at the top of the guide - Add TODOs for backup guidance, safety measures, and readiness checks - Fix misleading wording about systemd (cephadm replaces ceph-ansible, not systemd) - Clarify "manager node" as "OSISM manager node" throughout - Rename RGW/MDS sections from "Adopting" to "Migrating" (they can't be adopted in-place) - Move SSL setup before the RGW deploy command - Add concrete instructions for RGW service ID, placement, and port - Add concrete commands for reverting an adopted daemon AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-assisted: Claude Code