cmd: bump images to 0.246.0 and wire up --bootc-no-default-kernel-args#465
Open
supakeen wants to merge 3 commits intoosbuild:mainfrom
Open
cmd: bump images to 0.246.0 and wire up --bootc-no-default-kernel-args#465supakeen wants to merge 3 commits intoosbuild:mainfrom
--bootc-no-default-kernel-args#465supakeen wants to merge 3 commits intoosbuild:mainfrom
Conversation
This change brings fixes to the inspection of bootc build containers and the capability to turn off the injection of default kernel arguments for bootc image types. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Let users omit the default kernel arguments that are normally injected through the generic definitions that are embedded in `image-builder`. It is likely that the default in the future will be to always have this behaviour instead so this toggle lets users experiment with that future, or turn off the kernel arguments if they're harmful to their use-case. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
supakeen
requested review from
bcl,
croissanne and
lzap
and removed request for
a team
Newly introduced in `images` 0.246.0 is a lighter weight container inspection for the build container. Let's use it here. Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
Member
Author
|
@achilleas-k remind me, what is the failure here in the bib test cases, was it the depsolver adjustments? I think we can safely ignore it since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In osbuild/bootc-image-builder#824 it was pretty clear that our default kernel arguments (sometimes) get in the way of use cases.
After some discussion we likely want to, in the future, not ship any default kernel arguments at all. Since this is a breaking change we've put it behind a command-line flag for now; allowing those users that know what they want to turn off the default args.
In the future we might start a transition period to warn people that we'll stop injecting default kernel arguments; and that they can verify their containers by passing the
--bootc-no-default-kargsflag and the options they have: bootc dropins for managed state kernel args, or blueprints for unmanaged state.After that we'll likely drop the flag again once the default becomes "no kernel args".
Since this PR bumps images to
0.246.0it also closes #464 as I've adjusted the inspection for the build container to do basically nothing (as we don't need to know anything).