Skip to content

verbose logging fixes #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ondrejbudai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

verbose logging fixes #444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
056ffa4
main: fix --verbose logging
ondrejbudai Jan 28, 2026
c0a89cf
main: enable logrus in --verbose mode
ondrejbudai Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions cmd/image-builder/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"strings"
"syscall"

"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/spf13/pflag"

Expand Down Expand Up @@ -646,14 +647,23 @@ operating systems like Fedora, CentOS and RHEL with easy customizations support.

rootCmd.AddCommand(describeImgCmd)

verbose, err := rootCmd.PersistentFlags().GetBool("verbose")
if err != nil {
return err
}
if verbose {
olog.SetDefault(log.New(os.Stderr, "", 0))
// XXX: add once images has olog support
//images_log.SetDefault(log.New(os.Stderr, "", 0))
// Flags are not parsed yet, so we need to use this hook for enabling verbose logging for all commands
rootCmd.PersistentPreRunE = func(cmd *cobra.Command, args []string) error {
verbose, err := cmd.Flags().GetBool("verbose")
if err != nil {
return err
}
if verbose {
olog.SetDefault(log.New(os.Stderr, "", 0))
olog.Print("verbose logging enabled")
// osbuild/images still partially uses logrus, so enable it here as well
logrus.SetLevel(logrus.DebugLevel)
logrus.SetOutput(os.Stderr)
logrus.Debug("legacy logrus logging enabled")
// XXX: add once images has olog support, and drop logrus
//images_log.SetDefault(log.New(os.Stderr, "", 0))
}
return nil
}

return rootCmd.Execute()
Expand Down
Loading