Skip to content

Rename server_url to server_hostname in registrations #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lzap wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rename server_url to server_hostname in registrations #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ $ cat > registrations.json <<EOF
"subscription": {
"activation_key": "replace-with_activation_key",
"organization": "replace-with_org",
"server_url": "replace-with_server_url",
"base_url": "replace_with-base_url",
"server_hostname": "subscription.rhsm.redhat.com",
Copy link
Collaborator

@mvo5 mvo5 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AIUI we would have to change "images" here, no? This is just a direct mapping of https://github.com/osbuild/images/blob/423d32a0853f1f7ea6ab03507090a11903792dfe/pkg/customizations/subscription/subscription.go#L11 which is also used in composer. Don't get me wrong, I'm in favor for making this cleaner maybe we could just with alias fields or something so there is less risk of breaking anything?

Copy link
Contributor Author

@lzap lzap Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is why I am asking for opinions on how to approach this.

From what I remember, @achilleas-k was always for just "break it, fix it quickly".

"base_url": "https://cdn.redhat.com",
"insights": true,
"rhc": true,
"proxy": "replace-with_proxy"
Expand Down
Loading