Use ID_LIKE to figure out which bib file to use if a distro def doesn't exist.#1172
Use ID_LIKE to figure out which bib file to use if a distro def doesn't exist.#1172PizzaLovingNerd wants to merge 1 commit intoosbuild:mainfrom
Conversation
PizzaLovingNerd
requested review from
bcl,
croissanne and
supakeen
and removed request for
a team
supakeen
left a comment
supakeen
left a comment
There was a problem hiding this comment.
We have similar code elsewhere (which really means we should proceed with the merge) but for now @PizzaLovingNerd if you can address @bcl's comment this can go in :)
|
Just added BCL's suggestion, it will now log what it is trying if finds an ID_Like options. Sorry for the delay in the fix. |
|
Looks good, tests are failing due to: osbuild/images#2123 so let's have that merged first and then I'll retrigger them and this can go in. |
|
I've just pulled in new commits to ensure everything is fresh. Since osbuild/images#2123 was merged, can you please re-trigger the tests? Thanks! |
Done. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
github-actions
Bot
added
the
Stale
|
Hello, any updates on this? I cannot build ISOs with AlmaLinux's CI template atm and have to do it locally with my own fork. AlmaLinux bootc CI still uses the legacy_iso. |
bcl
left a comment
bcl
left a comment
There was a problem hiding this comment.
You've introduced a merge commit, we don't use those. Please rebase and squash things so that the commit history is clean.
Reapply the fork-specific stillOS legacy ISO handling on top of the latest upstream history without merge commits. Made-with: Cursor
|
My apologies, I needed to use my fork with the functionality to produce an ISO, so I updated it from upstream. Should be one commit now. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 participants
Also remove stillOS symlink as this commit removes the need for it.
I wanted to have a visible warning if this occurred, although I could not figure out how to display that in the CLI other than just adding it as a warning to the logs.