Use web URLs for reviews #186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes organicmaps#21 by replacing app store-specific URIs into website URLs which can be viewed by most platforms.
Member
|
Thanks!
|
Author
|
Opening web links directly into apps is supported since Android 6.0, but the web URLs must be verified to be opened in Android 12 and later. As of now the Google Play Store mobile site also offers "See in Play Store app" button to open the native app through
|
Member
|
It is not clear to me now whether will it work after the merge or not. Can we detect if it's an Android device, and if it's Android 5, and replace URLs dynamically using JS? |
rtsisyk
suggested changes
Dec 27, 2024
| @@ -1,5 +1,5 @@ | |||
| [appgallery]: https://appgallery.huawei.com/#/app/C104325611?local={{ lang }} "{{ trans(key='install-appgallery', lang=lang) }}" | |||
| [appgallery_review]: appmarket://details?id=app.organicmaps | |||
| [appgallery_review]: https://appgallery.huawei.com/#/app/C104325611?local={{ lang }} | |||
Contributor
There was a problem hiding this comment.
local= doesn't seem to be working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #21 by replacing app store-specific URIs into website URLs which can be viewed by most platforms.