Skip to content

Conversation

@kenjiestaana-ordermentum
Copy link

@kenjiestaana-ordermentum kenjiestaana-ordermentum commented Jul 18, 2025

Description

Overview
Provide a clear, concise summary of the purpose and impact of these changes.

  • Upgrade the version of axios to 1.7.9 to resolve typecheck issues

PR Type

Check one or more and add the corresponding number of reviewers

  • Bugfix or minor change (1)
  • Feature (2)
  • Breaking change (existing functionality no longer works as expected) (2)
  • Critical impact (security, payments or critical functionality) (2+CTO)

Changes

List the main changes in this PR. Include screenshots if necessary.


Testing

Acceptance Criteria

  • Explicitly list measurable conditions that validate the implementation
  • Include specific scenarios or edge cases tested

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • E2E tests added/updated
  • Manual testing completed

Checklist

Code Quality

  • No commented-out code
  • Appropriate logging added
  • No hardcoded credentials/secrets

Functionality

  • Tested with non-admin user
  • Works across different user roles
  • Backward compatibility maintained

Deployment Readiness

  • Rebased against latest develop branch
  • Feature flag implemented (if new feature)
  • Database migrations reviewed
  • Can be safely released to production

Security

  • Input validation implemented
  • Proper error handling
  • No exposed sensitive information
  • Follows least privilege principle

Performance

  • No unintended performance regressions
  • Benchmarks/profiling performed if applicable

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: 47df793

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kenjiestaana-ordermentum
Copy link
Author

Hi @sugendran @tjcoyoca, I'm closing this PR as it doesn't resolve the type-checking issues in OM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants