fix(heartbeat): include file path in JSON parse errors#6
Open
oratis wants to merge 1 commit into
Open
Conversation
`loadHeartbeatConfig` was the odd one out among the three user-config loaders — `mcp/config.ts` and `channels/config.ts` both wrap their `JSON.parse` to surface the offending path; this one threw a bare `SyntaxError: Unexpected token …` so a user with a typo in `~/.lisa/heartbeat.json` would see a stack trace into our compiled JS with no breadcrumbs back to their own config file. Match the existing sibling pattern. Same `failed to parse <path>: <err>` wording. Closes #5 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5.
What
loadHeartbeatConfigwas the only user-config loader of the three that didn't tag JSON parse failures with the offending file path:mcp/config.ts~/.lisa/mcp.jsonchannels/config.ts~/.lisa/channels.jsonheartbeat/config.ts~/.lisa/heartbeat.jsonA user with a typo in
heartbeat.jsongotSyntaxError: Unexpected token …pointing at compileddist/heartbeat/config.jswith no hint that the problem was in their own config.Change
Match the existing sibling pattern (same wording, same shape):
Scope
npm run typecheckclean.🤖 Generated with Claude Code