Change JUnit dependency scope from compile to scope#666
Open
ThomasVitale wants to merge 1 commit intooras-project:mainfrom
Open
Change JUnit dependency scope from compile to scope#666ThomasVitale wants to merge 1 commit intooras-project:mainfrom
ThomasVitale wants to merge 1 commit intooras-project:mainfrom
Conversation
Fixes oras-projectgh-665 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
org.junit.jupiter:junit-jupiter-paramsdependency was mistakenly declared withcompilescope, resulting in it being included in the final production artifact published to Maven Central. I fixed it by declaring it withtestscope.Fixes gh-665
Testing done
I ran the entire test suite and it succeeded.
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR