[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12265] Add experiments field to Holdout data model#625
Open
muzahidul-opti wants to merge 2 commits intomasterfrom
Open
[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12265] Add experiments field to Holdout data model#625muzahidul-opti wants to merge 2 commits intomasterfrom
muzahidul-opti wants to merge 2 commits intomasterfrom
Conversation
- Add experiments field to Holdout struct with default empty array - Add isLocal computed property to identify local holdouts - Add experimentHoldoutsMap to HoldoutConfig for O(1) lookups - Add getHoldoutsForExperiment() method for experiment-based queries - Add comprehensive unit tests for new functionality - Maintain backward compatibility with existing datafiles Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Combined experiment and flag mapping into single loop: - Check experiments first - if present, build experiment map and skip flag logic - If no experiments, proceed with flag-level logic - More efficient (single pass) and clearer separation between local and global holdouts Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds experiments field to Holdout data model to support local holdouts (MVP 3), allowing holdouts to target specific experiments instead of entire flags.
Changes
Jira Ticket
FSSDK-12265
Notes
🤖 Generated with Claude Code