[AI-FSSDK] [TESTING] do not review#516
Open
jaeopt wants to merge 1 commit into
Open
Conversation
Change identify_user call chain to accept identifiers dict instead of single user_id string. Only send ODP identify event when 2+ valid (non-null, non-empty) identifiers exist. Filter out null/empty values before counting. Add tests for single, multiple, zero identifiers and null/empty value filtering.
jaeopt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip ODP identify event dispatch when only a single identifier is provided (e.g., just
fs_user_id). Send ODP identify event only when 2+ valid (non-null, non-empty) identifiers exist, and propagate identifiers as a dict through the full identify call chain instead of a plain user_id string.Changes
identify_usercall chain to accept and forward an identifiers dict instead of a singleuser_idstringJira Ticket
FSSDK-12721