[AI-FSSDK] [TESTING] do not review#514
Closed
jaeopt wants to merge 1 commit into
Closed
Conversation
…count Skip ODP identify event when only one identifier is provided. Send identify event only when 2+ valid (non-empty) identifiers exist. Propagate identifiers as dict through the identify_user call chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs_user_id)dict[str, str]through the fullidentify_usercall chain instead of a plainuser_idstringChanges
Production code:
OdpEventManager.identify_user— acceptsidentifiers: dict[str, str]and passes directly tosend_eventOdpManager.identify_user— acceptsidentifiers: dict[str, str], filters empty values, checks count >= 2 before forwardingOptimizely._identify_user— accepts and forwardsidentifiers: dict[str, str]OptimizelyUserContext.__init__— constructs identifiers map fromuser_idand passes to_identify_userTests updated:
test_odp_manager.py— replaced old single-string tests with new dict-based tests covering: single identifier skipped, empty values not counted, multiple identifiers sent, ODP disabled/not-integrated preservedtest_user_context.py— updated assertions to expect identifiers dicttest_optimizely.py— updated assertions to expect identifiers dictJira
FSSDK-12721
QA Summary