Skip to content

[AI-FSSDK] [TESTING] do not review#514

Closed
jaeopt wants to merge 1 commit into
masterfrom
ai/jaeopt/FSSDK-12721-clean-build-test-2
Closed

[AI-FSSDK] [TESTING] do not review#514
jaeopt wants to merge 1 commit into
masterfrom
ai/jaeopt/FSSDK-12721-clean-build-test-2

Conversation

@jaeopt
Copy link
Copy Markdown
Contributor

@jaeopt jaeopt commented Jun 1, 2026

Summary

  • Skip ODP identify event dispatch when only a single identifier is provided (e.g., just fs_user_id)
  • Send ODP identify event only when 2+ valid (non-null, non-empty) identifiers exist
  • Propagate identifiers as dict[str, str] through the full identify_user call chain instead of a plain user_id string

Changes

Production code:

  • OdpEventManager.identify_user — accepts identifiers: dict[str, str] and passes directly to send_event
  • OdpManager.identify_user — accepts identifiers: dict[str, str], filters empty values, checks count >= 2 before forwarding
  • Optimizely._identify_user — accepts and forwards identifiers: dict[str, str]
  • OptimizelyUserContext.__init__ — constructs identifiers map from user_id and passes to _identify_user

Tests updated:

  • test_odp_manager.py — replaced old single-string tests with new dict-based tests covering: single identifier skipped, empty values not counted, multiple identifiers sent, ODP disabled/not-integrated preserved
  • test_user_context.py — updated assertions to expect identifiers dict
  • test_optimizely.py — updated assertions to expect identifiers dict

Jira

FSSDK-12721

QA Summary

  • Iteration: 1/5
  • ruff: PASS
  • mypy: PASS (11 pre-existing errors, 0 new)
  • pytest: 955/955 PASS

…count

Skip ODP identify event when only one identifier is provided.
Send identify event only when 2+ valid (non-empty) identifiers exist.
Propagate identifiers as dict through the identify_user call chain.
@jaeopt jaeopt changed the title [AI-FSSDK] [FSSDK-12721] ODP identify event - conditional send based on identifier count [AI-FSSDK] [TESTING] do not review Jun 1, 2026
@jaeopt jaeopt closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant