Skip to content

[FSSDK-10941] move notification_center to the lib root directory #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raju-opti merged 1 commit into from
Nov 26, 2024
Merged

[FSSDK-10941] move notification_center to the lib root directory #970

raju-opti merged 1 commit into from
Nov 26, 2024

Conversation

@raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Nov 26, 2024

Summary

  • move notification_center to the lib root directory

Test plan

Issues

  • FSSDK-10941

@raju-opti raju-opti requested a review from a team as a code owner November 26, 2024 14:20
@coveralls
Copy link

coveralls commented Nov 26, 2024

Coverage Status

coverage: 86.916%. remained the same
when pulling 3d9cd73 on raju/cleanup_notification
into 95ea7d3 on master.

junaed-optimizely
junaed-optimizely approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit 5929210 into master Nov 26, 2024
16 of 19 checks passed
@raju-opti raju-opti deleted the raju/cleanup_notification branch November 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@junaed-optimizely junaed-optimizely

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raju-opti @coveralls @junaed-optimizely