[AI-FSSDK] [FSSDK-12337] Add Feature Rollout support#1140
Open
FarhanAnjum-opti wants to merge 4 commits intomasterfrom
Open
[AI-FSSDK] [FSSDK-12337] Add Feature Rollout support#1140FarhanAnjum-opti wants to merge 4 commits intomasterfrom
FarhanAnjum-opti wants to merge 4 commits intomasterfrom
Conversation
raju-opti
requested changes
Mar 30, 2026
lib/project_config/project_config.ts
Outdated
| const validExperimentTypes = new Set(Object.values(EXPERIMENT_TYPES)); | ||
| (projectConfig.experiments || []).forEach(experiment => { | ||
| if (experiment.type != null && !validExperimentTypes.has(experiment.type)) { | ||
| throw new OptimizelyError( |
Contributor
There was a problem hiding this comment.
this should not throw if the experiment type is unrecognized, otherwise this version of the SDK will throw errors if a new rule type is added in future datafiles
lib/project_config/project_config.ts
Outdated
| }); | ||
| // Update variation lookup maps | ||
| experiment.variationKeyMap[everyoneElseVariation.key] = everyoneElseVariation; | ||
| projectConfig.variationIdMap[everyoneElseVariation.id] = everyoneElseVariation; |
Contributor
There was a problem hiding this comment.
projectConfig.variationIdMap and projectConfig.variationVariableUsageMap should already contain the correct values. We can remove these two lines
raju-opti
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Feature Rollout support to the JavaScript SDK. Feature Rollouts are a new experiment rule type that combines Targeted Delivery simplicity with A/B test measurement capabilities. During project config parsing, the "everyone else" variation from the flag's rollout is injected into any experiment with type "feature_rollout", enabling correct evaluation without changes to decision logic.
Changes
typestring field to the Experiment interfacegetEveryoneElseVariationhelper function to extract the last rollout rule's first variationJira Ticket
FSSDK-12337