Skip to content

[matjaz-3-sdks] [AI-FSSDK] (DO NOT REVIEW) [FSSDK-12248] Increase max retry time interval to 3 secs #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mat001 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

[matjaz-3-sdks] [AI-FSSDK] (DO NOT REVIEW) [FSSDK-12248] Increase max retry time interval to 3 secs #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/event_processor/batch_event_processor.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
import { expect, describe, it, vi, beforeEach, afterEach, MockInstance } from 'vitest';

import { EventWithId, BatchEventProcessor, LOGGER_NAME } from './batch_event_processor';
import { EventWithId, BatchEventProcessor, LOGGER_NAME, DEFAULT_MIN_BACKOFF, DEFAULT_MAX_BACKOFF } from './batch_event_processor';
import { getMockAsyncCache, getMockSyncCache } from '../tests/mock/mock_cache';
import { createImpressionEvent } from '../tests/mock/create_event';
import { ProcessableEvent } from './event_processor';
Expand Down Expand Up @@ -52,6 +52,11 @@ describe('BatchEventProcessor', async () => {
vi.useRealTimers();
});

it('should have correct default retry backoff constants', () => {
expect(DEFAULT_MIN_BACKOFF).toBe(200);
expect(DEFAULT_MAX_BACKOFF).toBe(3000);
});

it('should set name on the logger passed into the constructor', () => {
const logger = getMockLogger();

Expand Down
2 changes: 1 addition & 1 deletion lib/event_processor/batch_event_processor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { SERVICE_STOPPED_BEFORE_RUNNING } from "../service";
import { Platform } from '../platform_support';

export const DEFAULT_MIN_BACKOFF = 200;
export const DEFAULT_MAX_BACKOFF = 1000;
export const DEFAULT_MAX_BACKOFF = 3000;
export const MAX_EVENTS_IN_STORE = 500;

export type EventWithId = {
Expand Down
Loading