Skip to content

remove obselete validation #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junaed-optimizely merged 2 commits into from
Mar 12, 2025
Merged

remove obselete validation #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff25b5
remove obselete validation
raju-opti Mar 12, 2025
eaf792d
skipping test for now
junaed-optimizely Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/utils/config_validator/index.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import {
describe('lib/utils/config_validator', function() {
describe('APIs', function() {
describe('validate', function() {
it('should complain if the provided error handler is invalid', function() {
it.skip('should complain if the provided error handler is invalid', function() {
const ex = assert.throws(function() {
configValidator.validate({
errorHandler: {},
Expand All @@ -39,7 +39,7 @@ describe('lib/utils/config_validator', function() {
assert.equal(ex.baseMessage, INVALID_ERROR_HANDLER);
});

it('should complain if the provided event dispatcher is invalid', function() {
it.skip('should complain if the provided event dispatcher is invalid', function() {
const ex = assert.throws(function() {
configValidator.validate({
eventDispatcher: {},
Expand All @@ -48,7 +48,7 @@ describe('lib/utils/config_validator', function() {
assert.equal(ex.baseMessage, INVALID_EVENT_DISPATCHER);
});

it('should complain if the provided logger is invalid', function() {
it.skip('should complain if the provided logger is invalid', function() {
const ex = assert.throws(function() {
configValidator.validate({
logger: {},
Expand Down
13 changes: 1 addition & 12 deletions lib/utils/config_validator/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,18 +43,7 @@ const SUPPORTED_VERSIONS = [DATAFILE_VERSIONS.V2, DATAFILE_VERSIONS.V3, DATAFILE
export const validate = function(config: unknown): boolean {
if (typeof config === 'object' && config !== null) {
const configObj = config as ObjectWithUnknownProperties;
const errorHandler = configObj['errorHandler'];
const eventDispatcher = configObj['eventDispatcher'];
const logger = configObj['logger'];
if (errorHandler && typeof (errorHandler as ObjectWithUnknownProperties)['handleError'] !== 'function') {
throw new OptimizelyError(INVALID_ERROR_HANDLER);
}
if (eventDispatcher && typeof (eventDispatcher as ObjectWithUnknownProperties)['dispatchEvent'] !== 'function') {
throw new OptimizelyError(INVALID_EVENT_DISPATCHER);
}
if (logger && typeof (logger as ObjectWithUnknownProperties)['info'] !== 'function') {
throw new OptimizelyError(INVALID_LOGGER);
}
// TODO: add validation
return true;
}
throw new OptimizelyError(INVALID_CONFIG);
Expand Down
Loading