[AI-FSSDK] [TESTING] do not review#411
Open
jaeopt wants to merge 1 commit into
Open
Conversation
Change IdentifyUser call chain to accept Dictionary<string, string> identifiers instead of single userId string. Only send ODP identify event when 2+ valid (non-null, non-empty) identifiers exist. Filter out null/empty values before counting. Add tests for single identifier (skipped), multiple identifiers (sent), and null/empty value filtering. Update existing tests to use dict-based identifier propagation.
jaeopt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip ODP identify event dispatch when only a single identifier is provided (e.g., just
fs_user_id). Send ODP identify event only when 2+ valid (non-null, non-empty) identifiers exist, and propagate identifiers as a Dictionary through the full IdentifyUser call chain instead of a plain userId string.Changes
IdentifyUsercall chain (interfaces and implementations) to accept and forward aDictionary<string, string>instead of a singleuserIdstringJira Ticket
FSSDK-12721