-
Notifications
You must be signed in to change notification settings - Fork 2
fix: resolve dogfood issues #408–#411 #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3841317
fix: isolate benchmark engine/model failures with try/catch (#408)
carlos-alm 583d995
fix: dispose WASM tree-sitter parsers and trees to prevent segfaults …
carlos-alm d989e6e
fix: track dynamic import() expressions in native engine (#410)
carlos-alm 9fc84de
fix: report correct native engine version from package.json (#411)
carlos-alm 7fb4afa
fix: address Greptile review feedback on #418
carlos-alm 9844b2e
Merge branch 'main' into fix/issues-408-411
carlos-alm a55717a
fix: address review feedback on #408–#411
carlos-alm 2fd67f0
Merge remote-tracking branch 'origin/main' into fix/issues-408-411
carlos-alm 40abead
Merge branch 'fix/issues-408-411' of https://github.com/optave/codegr…
carlos-alm 3f4adca
Merge branch 'main' into fix/issues-408-411
carlos-alm fe6d978
fix: deduplicate native.js import in info command
carlos-alm 381548e
Merge branch 'fix/issues-408-411' of https://github.com/optave/codegr…
carlos-alm d22a6ac
fix: address round-2 review feedback
carlos-alm 1582b65
fix: handle object_assignment_pattern in dynamic import destructuring
carlos-alm 20203c2
fix: handle array_pattern bindings in dynamic import destructuring
carlos-alm bbfd0c7
fix: use null-safe error message pattern in embedding-benchmark
carlos-alm 32b0762
Merge branch 'main' into fix/issues-408-411
carlos-alm 7d55362
fix: dispose cached Language objects in disposeParsers()
carlos-alm de32c38
fix: handle rest_pattern and nested destructuring in dynamic imports
carlos-alm 53ce6bd
fix: handle rest_pattern in array_pattern for dynamic imports
carlos-alm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array_patternbindings silently dropped from dynamic importsThe
extract_dynamic_import_namesfunction handlesobject_patterndestructuring and plainidentifierbindings, but notarray_pattern. In JavaScript, array destructuring from a dynamic import is valid:Tree-sitter parses the
namenode as anarray_patternhere. The currentmatch name_node.kind()falls through to_ => Vec::new(), so the import edge is emitted (the path is resolved correctly) but zero bindings are captured. Consumers that rely on names to resolve which exports are used will silently miss these.Consider adding an
"array_pattern"arm that iterates children and collectsidentifiernodes, similar to theobject_patternarm, or at a minimum document that array-pattern bindings are intentionally not supported yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 20203c2 — added an array_pattern arm to extract_dynamic_import_names that iterates children and collects identifier and assignment_pattern bindings.