Skip to content

Return news id on save so bot can pass it back #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregv merged 1 commit into from
May 17, 2026
Merged

Return news id on save so bot can pass it back #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions common/utils/firebase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,11 +1179,12 @@ def upsert_news(news):
news_messageTs = news_messageTs[0]
news_messageTs = news_messageTs.reference
db.collection("news").document(news_messageTs.id).set(news, merge=True)
return news_messageTs
return news_messageTs.id
else:
logger.info("news does not exist")

db.collection("news").add(news)
_, doc_ref = db.collection("news").add(news)
return doc_ref.id

def upsert_praise(praise):
db = get_db() # this connects to our Firestore database
Expand Down
6 changes: 4 additions & 2 deletions services/news_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,16 @@ def save_news(json):
news_image = generate_and_save_image_to_cdn(cdn_dir, json["title"])
json["image"] = f"{CDN_SERVER}/{cdn_dir}/{news_image}"
json["last_updated"] = datetime.now().isoformat()
upsert_news(json)
news_id = upsert_news(json)

logger.info("Updated news successfully")

get_news.cache_clear()
logger.info("Cleared cache for get_news")

return Message("Saved News")
msg = Message("Saved News")
msg.id = news_id
return msg


def save_praise(json):
Expand Down
Loading