Skip to content

sysutils/nut: fix upsstatus diagnostics and netclient model definition #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Drinker09 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sysutils/nut: fix upsstatus diagnostics and netclient model definition #5469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a1d722
sysutils/nut: fix upsstatus to use direct NUT protocol socket instead…
May 28, 2026
641b713
sysutils/nut: fix netclient address HostnameField definition in model
Drinker09 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions sysutils/nut/src/opnsense/mvc/app/controllers/OPNsense/Nut/Api/DiagnosticsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
namespace OPNsense\Nut\Api;

use OPNsense\Base\ApiControllerBase;
use OPNsense\Core\Backend;
use OPNsense\Nut\Nut;

class DiagnosticsController extends ApiControllerBase
Expand All @@ -41,12 +40,40 @@ public function upsstatusAction()
if (!empty((string)$mdl->netclient->address)) {
$host = (string)$mdl->netclient->address;
}
$port = 3493;
if (!empty((string)$mdl->netclient->port)) {
$port = (int)(string)$mdl->netclient->port;
}
$upsname = 'UPSName';
if (!empty((string)$mdl->general->name)) {
$upsname = (string)$mdl->general->name;
}
$backend = new Backend();
$response = $backend->configdpRun('nut upsstatus', array("{$upsname}@{$host}"));

$response = '';
$socket = @fsockopen($host, $port, $errno, $errstr, 5);
if ($socket) {
fwrite($socket, "LIST VAR {$upsname}\n");
$raw = '';
while (!feof($socket)) {
$raw .= fgets($socket, 1024);
if (strpos($raw, "END LIST VAR") !== false) break;
}
fclose($socket);

// Transform "VAR upsname key "value"" to "key: value"
foreach (explode("\n", $raw) as $line) {
if (strpos($line, "VAR {$upsname} ") === 0) {
$line = substr($line, strlen("VAR {$upsname} "));
$parts = explode(' ', $line, 2);
if (count($parts) == 2) {
$key = $parts[0];
$value = trim($parts[1], " \"\r\n");
$response .= "{$key}: {$value}\n";
}
}
}
}

return array("response" => $response);
}
}
}
5 changes: 4 additions & 1 deletion sysutils/nut/src/opnsense/mvc/app/models/OPNsense/Nut/Nut.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@
<Required>Y</Required>
<Default>0</Default>
</enable>
<address type="HostnameField"/>
<address type="HostnameField">
<Required>N</Required>
<IpWithPrefix>N</IpWithPrefix>
</address>
<port type="PortField">
<Default>3493</Default>
<Required>N</Required>
Expand Down