[os-tailscale] Support tailscale set arguments#5382
Open
AlexRusbridge wants to merge 5 commits intoopnsense:masterfrom
Open
[os-tailscale] Support tailscale set arguments#5382AlexRusbridge wants to merge 5 commits intoopnsense:masterfrom
tailscale set arguments#5382AlexRusbridge wants to merge 5 commits intoopnsense:masterfrom
Conversation
…figuration options
Contributor
|
This looks like a promising idea, let me have a look over it and ensure nothing breaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Related issue
Describe the problem
Tailscale have a preference for adding new flags to the
tailscale setcommand, instead oftailscale up.This means that any new functionality added to
tailscaleis likely to be configured throughset. In the plugins current state, we can't configure these options.We can already see the impact with the
--relay-server-portflag.Describe the proposed solution
This PR adds a new rc.d script
tailscaled_setthat will applytailscale setflags after thetailscaledservice has started.It supports defining arguments via the
tailscaled_set_argsvariable.For now, we can configure
--relay-server-portand--webclientvia the UI. But this PR opens up the possibility of moresetarguments.Note: There is another solution, where the FreeBSD port of
tailscaledcould supporttailscaled_set_argsalongside it'stailscaled_set_args.