frr: Extend usage of "localip" option to enforce source-ip of BGP tcp session#5363
Open
n3wtype wants to merge 1 commit intoopnsense:masterfrom
Open
frr: Extend usage of "localip" option to enforce source-ip of BGP tcp session#5363n3wtype wants to merge 1 commit intoopnsense:masterfrom
n3wtype wants to merge 1 commit intoopnsense:masterfrom
Conversation
…/179 session. Previously "localip" was only used for MD5 Authentication purpose. It was not affecting actuall source-ip used to establish BGP and BFD sessions. Using "updatesource" option was not possible to select specific ip-address. This caused undeterministic address selection for interfaces with multiple ip, it required settings outside of FRR (lika SNAT) to enforce expected IP. After change "localip" when defined is also used as value of update-source param in frr. It takes precedense over interface specified in "updatesource" option
Member
|
There might be regressions for people when suddenly assuming different defaults for the same input, which might not be the end of the world, but to improve long term maintainability, we should add a validation and make this explicit for the user. It's not overly complicated, but does mean more work is needed (a migration to enforce the options and a validation to signal the user about this constraint when chosen). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
#5362
** solved problem **
Previously "localip" was only used for MD5 Authentication purpose. It was not affecting actuall source-ip used to establish BGP and BFD sessions. Using "updatesource" option was not possible to select specific ip-address. This caused undeterministic address selection for interfaces with multiple ip, it required settings outside of FRR (lika SNAT) to enforce expected IP.
** change made **
After change "localip" when defined is also used as value of update-source param in frr. It takes precedense over interface specified in "updatesource" option