dns/ddnsclient: add TransIP support#5229
Open
mgroenhoff wants to merge 1 commit intoopnsense:masterfrom
Open
Conversation
7306e9d to
a568a89
Compare
a568a89 to
55664f6
Compare
Author
|
How do I request a review? Do I need to create an issue first? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using an older version of this code for quite some time now and finally found the time to polish and submit it.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Related issue
No issue (yet)
Describe the problem
While the acme client has TransIP support, ddnsclient has not (yet)
Describe the proposed solution
Add ddnsclient service for TransIP
API Docs: https://api.transip.nl/rest/docs.html#header-authentication
Relevant Account Settings: