dns/bind: Added options to control recursion #4897
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2025
fichtner
reviewed
Aug 15, 2025
fichtner
reviewed
Aug 15, 2025
fichtner
reviewed
Aug 15, 2025
fichtner
reviewed
Aug 15, 2025
dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/general.xml
Show resolved
Hide resolved
fichtner
reviewed
Aug 15, 2025
dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/general.xml
Outdated
Show resolved
Hide resolved
Adds options to control recursion: 1. Adds an option to explicitly enable recursion, when unchecked sets recursion=no 2. Adds an option for allow-query-cache, which effectively controls recursion 3. Updated help and reformatted Signed-off-by: benyamin-codez <115509179+benyamin-codez@users.noreply.github.com>
benyamin-codez
force-pushed
the
bind-disable-recursion
branch
from
52aa6e7 to
f6810e6
Compare
Contributor
Author
|
@fichtner, just those last two unresolved convos methinks... |
fichtner
reviewed
Aug 15, 2025
dns/bind/src/opnsense/mvc/app/controllers/OPNsense/Bind/forms/general.xml
Show resolved
Hide resolved
fichtner
approved these changes
Aug 15, 2025
Member
fichtner
left a comment
fichtner
left a comment
There was a problem hiding this comment.
ok from me, giving a bit of review time to @mimugmail
Contributor
Author
|
This PR also bumps the General model to v1.0.13, but leaving the message alone so as to avoid the required force-push... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds options to control recursion:
Split from PR #4892.
Resolves #4887