Skip to content

[#330] 네트워크가 연결되어있음에도 앱을 시작할 시 간헐적으로 네트워크 관련 얼럿이 뜨는 현상을 해결한다 #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opficdev merged 2 commits into from
Mar 29, 2026
Merged

[#330] 네트워크가 연결되어있음에도 앱을 시작할 시 간헐적으로 네트워크 관련 얼럿이 뜨는 현상을 해결한다 #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a995d
refactor: 옵셔널 포함하지만, 방출을 compactMap으로 처리하여 최초 Bool 값을 방출하지 않도록 개선
opficdev Mar 29, 2026
647b60f
style: 유즈케이스 단에서 removeDuplicates() 적용
opficdev Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions DevLog/Domain/UseCase/Connectivity/ObserveNetworkConnectivityUseCaseImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,7 @@ final class ObserveNetworkConnectivityUseCaseImpl: ObserveNetworkConnectivityUse

func observe() -> AnyPublisher<Bool, Never> {
repository.observeNetworkConnectivity()
.removeDuplicates()
.eraseToAnyPublisher()
}
}
9 changes: 4 additions & 5 deletions DevLog/Infra/Service/NWPathConnectivityProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,9 @@ import Combine
final class NWPathConnectivityProvider {
private let networkPathMonitor = NWPathMonitor()
private let monitoringQueue = DispatchQueue(label: "NWPathConnectivityProviderQueue")
private let isConnectedSubject = CurrentValueSubject<Bool, Never>(false)
private let isConnectedSubject = CurrentValueSubject<Bool?, Never>(nil)

init() {
let initialStatus = networkPathMonitor.currentPath.status == .satisfied
isConnectedSubject.send(initialStatus)

networkPathMonitor.pathUpdateHandler = { [weak self] path in
let connected = (path.status == .satisfied)
self?.isConnectedSubject.send(connected)
Expand All @@ -30,6 +27,8 @@ final class NWPathConnectivityProvider {
}

func observeNetworkConnectivity() -> AnyPublisher<Bool, Never> {
isConnectedSubject.eraseToAnyPublisher()
isConnectedSubject
.compactMap { $0 }
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

네트워크 연결 상태가 변경될 때만 이벤트를 방출하도록 removeDuplicates() 연산자를 추가하는 것을 고려해 보세요. pathUpdateHandler는 연결 상태(status)가 동일하더라도 다른 경로 속성(예: 사용 가능한 인터페이스 변경)이 변경될 때마다 호출될 수 있습니다. removeDuplicates()를 사용하면 불필요한 중복 true 또는 false 값의 전송을 막아 다운스트림 구독자의 부하를 줄일 수 있습니다.

Suggested change
.compactMap { $0 }
.compactMap { $0 }
.removeDuplicates()

.eraseToAnyPublisher()
}
}
1 change: 0 additions & 1 deletion DevLog/Presentation/ViewModel/HomeViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,6 @@ private extension HomeViewModel {

func setupNetworkObserving() {
networkConnectivityUseCase.observe()
.removeDuplicates()
.receive(on: DispatchQueue.main)
.sink { [weak self] isConnected in
self?.send(.networkStatusChanged(isConnected))
Expand Down
1 change: 0 additions & 1 deletion DevLog/Presentation/ViewModel/ProfileViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ final class ProfileViewModel: Store {
extension ProfileViewModel {
private func setupNetworkObserving() {
networkConnectivityUseCase.observe()
.removeDuplicates()
.receive(on: DispatchQueue.main)
.sink { [weak self] isConnected in
self?.send(.networkStatusChanged(isConnected))
Expand Down
1 change: 0 additions & 1 deletion DevLog/Presentation/ViewModel/RootViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ private extension RootViewModel {

func setupNetworkObserving() {
networkConnectivityUseCase.observe()
.removeDuplicates()
.receive(on: DispatchQueue.main)
.sink { [weak self] isConnected in
self?.send(.networkStatusChanged(isConnected))
Expand Down
1 change: 0 additions & 1 deletion DevLog/Presentation/ViewModel/SettingViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ private extension SettingViewModel {

func setupNetworkObserving() {
networkConnectivityUseCase.observe()
.removeDuplicates()
.receive(on: DispatchQueue.main)
.sink { [weak self] isConnected in
self?.send(.networkStatusChanged(isConnected))
Expand Down