Skip to content

Cleanup crowdin workflow#22519

Merged
toy merged 2 commits intodevfrom
fix-crowdin
Apr 9, 2026
Merged

Cleanup crowdin workflow#22519
toy merged 2 commits intodevfrom
fix-crowdin

Conversation

@toy
Copy link
Copy Markdown
Contributor

@toy toy commented Mar 26, 2026

Improvements to crowdin workflow:

@toy toy force-pushed the fix-crowdin branch 5 times, most recently from 7b180d7 to 4531309 Compare March 26, 2026 16:39
@toy toy marked this pull request as ready for review March 26, 2026 19:24
@toy toy requested review from Copilot and oliverguenther March 26, 2026 19:24
@toy toy changed the title Fix crowdin Fix crowdin workflow Mar 26, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Crowdin translation sync workflow to avoid file ownership fixes, normalize downloaded translation YAMLs, and simplify the Portuguese root-key correction script.

Changes:

  • Switch Crowdin GitHub Action to an OPF fork and remove the post-download chown step.
  • Add a workflow step to rewrite downloaded Crowdin YAML files via a Ruby-based rewriter script.
  • Refactor fix_crowdin_pt_language_root_key to centralize GNU/BSD sed -i handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
script/i18n/fix_crowdin_pt_language_root_key Refactors sed -i handling into a helper and runs the two substitutions via the helper.
.github/workflows/crowdin.yml Switches to a forked Crowdin action, removes ownership-fix step, and adds a YAML rewrite step after download.

Comment thread .github/workflows/crowdin.yml
Comment thread .github/workflows/crowdin.yml Outdated
Comment thread script/i18n/fix_crowdin_pt_language_root_key Outdated
@toy toy force-pushed the fix-crowdin branch 3 times, most recently from 6bdc608 to c576c9b Compare April 2, 2026 13:50
@toy toy changed the title Fix crowdin workflow Cleanup crowdin workflow Apr 8, 2026
@toy toy merged commit d3e204c into dev Apr 9, 2026
13 of 16 checks passed
@toy toy deleted the fix-crowdin branch April 9, 2026 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants