Skip to content

Conversation

@perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Dec 24, 2025

Description of the change:

It seems the warning about not having a default values for the grpc health probe version is causing goreleaser/linux job to fail. This sets the default version in the Dockerfile ARG for the grpc health probe version.

Motivation for the change:

For some reason #1866 merged even though the goreleaser/linux job failed. Now, it's permafailing on master:
https://github.com/operator-framework/operator-registry/actions/runs/20485141309/job/58866008209

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci openshift-ci bot requested review from anik120 and joelanford December 24, 2025 11:37
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.49%. Comparing base (2834aa4) to head (232e633).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
- Coverage   57.50%   57.49%   -0.01%     
==========================================
  Files         136      136              
  Lines       12934    12934              
==========================================
- Hits         7438     7437       -1     
- Misses       4341     4342       +1     
  Partials     1155     1155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the fix-attestations branch 2 times, most recently from 6e202c3 to d72d92f Compare December 24, 2025 11:50
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva changed the title Setup docker-container as buildx driver Fix goreleaser Dec 24, 2025
@perdasilva perdasilva changed the title Fix goreleaser Fix goreleaser/linux job Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant