Auto-generate OpenAPIModelName() via openapi-gen#3769
Conversation
| // +k8s:conversion-gen=github.com/operator-framework/operator-lifecycle-manager/pkg/package-server/apis/operators | ||
| // +k8s:defaulter-gen=TypeMeta | ||
| // +k8s:openapi-gen=true | ||
| // +k8s:openapi-model-package=com.github.operator-framework.operator-lifecycle-manager.pkg.package-server.apis.operators.v1 |
There was a problem hiding this comment.
So I think we do not need to revert: #3765
That solves all :-)
There was a problem hiding this comment.
We're not reverting it, but this deletes the original file and moves the file to the generated filename.
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
That will impact other generation as well that already includes that boilerplate. Are you sure you want to do that? |
Replace hand-written model_name.go with generated zz_generated.model_name.go by adding +k8s:openapi-model-package marker to doc.go and running openapi-gen in update_codegen.sh. Update boilerplate.go.txt to remove Red Hat copyright. Signed-off-by: Todd Short <todd.short@me.com> Assisted-By: Claude
tmshort
force-pushed
the
add-openapi-model-names
branch
from
d27c6b4 to
0c96283
Compare
|
I removed the Red Hat copyright, and this updated a number of file headers. |
|
/approve |
grokspawn
removed
lgtm
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, grokspawn, rashmigottipati The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 68059b8
into
operator-framework:master
4 participants
Replace hand-written model_name.go with generated zz_generated.model_name.go by adding +k8s:openapi-model-package marker to doc.go and running openapi-gen in update_codegen.sh.
Assisted-By: Claude
Updates to #3755, #3765, #3767