WIP 🐛 fix(Boxcutter): Re-resolve bundle when progression deadline is exceeded during rollout#2570
Conversation
…ed during rollout Generated-by: Cursor/Claude
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Updates Boxcutter rollout behavior so that, during an active rollout, the controller only re-engages catalog resolution when the latest rolling-out revision has exceeded its progress deadline—enabling recovery from stuck rollouts without constantly re-resolving during normal progression.
Changes:
- Adjust
ResolveBundlelogic to reuse the latest rolling-out revision unless it hasProgressDeadlineExceeded, in which case it re-resolves from the catalog. - Add unit tests covering both “deadline exceeded → resolver called” and “deadline not exceeded → resolver not called” behaviors.
- Add an E2E scenario validating re-resolution after a rollout gets stuck and exceeds the progress deadline.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/e2e/features/update.feature |
Adds an E2E scenario asserting progress-deadline-driven re-resolution during a stuck rollout. |
internal/operator-controller/controllers/clusterextension_reconcile_steps.go |
Changes resolver engagement rules during active rollouts and adds a helper to detect ProgressDeadlineExceeded. |
internal/operator-controller/controllers/clusterextension_controller_test.go |
Adds unit tests for the new re-resolution vs reuse behavior based on progress deadline status. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2570 +/- ##
==========================================
+ Coverage 64.33% 68.64% +4.31%
==========================================
Files 131 131
Lines 9333 9342 +9
==========================================
+ Hits 6004 6413 +409
+ Misses 2853 2438 -415
- Partials 476 491 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.