Skip to content

WIP 🐛 fix(Boxcutter): Re-resolve bundle when progression deadline is exceeded during rollout#2570

Closed
camilamacedo86 wants to merge 1 commit intooperator-framework:mainfrom
camilamacedo86:fix-bug-joe-inputs
Closed

WIP 🐛 fix(Boxcutter): Re-resolve bundle when progression deadline is exceeded during rollout#2570
camilamacedo86 wants to merge 1 commit intooperator-framework:mainfrom
camilamacedo86:fix-bug-joe-inputs

Conversation

@camilamacedo86
Copy link
Contributor

No description provided.

…ed during rollout

Generated-by: Cursor/Claude
Copilot AI review requested due to automatic review settings March 17, 2026 07:32
@netlify
Copy link

netlify bot commented Mar 17, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 35b0289
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69b90385cc03e10008895525
😎 Deploy Preview https://deploy-preview-2570--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from OchiengEd and grokspawn March 17, 2026 07:32
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86 camilamacedo86 changed the title fix(Boxcutter): Re-resolve bundle when progression deadline is exceeded during rollout WIP 🐛 fix(Boxcutter): Re-resolve bundle when progression deadline is exceeded during rollout Mar 17, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Boxcutter rollout behavior so that, during an active rollout, the controller only re-engages catalog resolution when the latest rolling-out revision has exceeded its progress deadline—enabling recovery from stuck rollouts without constantly re-resolving during normal progression.

Changes:

  • Adjust ResolveBundle logic to reuse the latest rolling-out revision unless it has ProgressDeadlineExceeded, in which case it re-resolves from the catalog.
  • Add unit tests covering both “deadline exceeded → resolver called” and “deadline not exceeded → resolver not called” behaviors.
  • Add an E2E scenario validating re-resolution after a rollout gets stuck and exceeds the progress deadline.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/e2e/features/update.feature Adds an E2E scenario asserting progress-deadline-driven re-resolution during a stuck rollout.
internal/operator-controller/controllers/clusterextension_reconcile_steps.go Changes resolver engagement rules during active rollouts and adds a helper to detect ProgressDeadlineExceeded.
internal/operator-controller/controllers/clusterextension_controller_test.go Adds unit tests for the new re-resolution vs reuse behavior based on progress deadline status.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.64%. Comparing base (147cfa8) to head (35b0289).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
+ Coverage   64.33%   68.64%   +4.31%     
==========================================
  Files         131      131              
  Lines        9333     9342       +9     
==========================================
+ Hits         6004     6413     +409     
+ Misses       2853     2438     -415     
- Partials      476      491      +15     
Flag Coverage Δ
e2e 38.95% <0.00%> (-3.26%) ⬇️
experimental-e2e 51.67% <100.00%> (+39.80%) ⬆️
unit 53.88% <86.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants