feat: add OpenRewrite module for migrations and recipe for 5.3.0#3236
feat: add OpenRewrite module for migrations and recipe for 5.3.0#3236csviri wants to merge 12 commits intooperator-framework:mainfrom
Conversation
csviri
changed the title
csviri
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds a new migration module to the Java Operator SDK project, providing OpenRewrite recipes to automate migration from v5.2 to v5.3. The recipes handle dependency version upgrades, artifact renames, Metrics API method renames, and removal of deprecated method invocations.
Changes:
- New
migrationMaven module with OpenRewrite recipe definitions for v5.2→v5.3 migration (JUnit module rename, Metrics method renames, version upgrade,monitorSizeOfremoval) - Test class
V53MigrationTestvalidating the Maven artifact rename and Metrics method rename recipes - Documentation update adding OpenRewrite usage instructions to the v5.3 migration guide
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Adds the new migration module to the reactor build |
| migration/pom.xml | New module POM with OpenRewrite dependencies for recipe authoring and testing |
| migration/src/main/resources/META-INF/rewrite/v5-3-migration.yml | OpenRewrite recipe definitions for v5.3 migration |
| migration/src/test/java/.../V53MigrationTest.java | Tests for the JUnit module rename and Metrics method rename recipes |
| docs/content/en/docs/migration/v5-3-migration.md | Adds OpenRewrite automated migration instructions |
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| default void reconciliationFinished(Object resource, RetryInfo retryInfo, Map<String, Object> metadata) {} |
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
|
added additional improvements, but I think we should stop there, this already adresses most of the issues; there are some others but those are quite deep rabit holes |
| with: | ||
| distribution: temurin | ||
| java-version: 25 | ||
| java-version: 17 |
There was a problem hiding this comment.
Had to change this is open rewrite is jvm specific there is an issue with AbstractSyntaxtTree (AST) when having this on java 25. I'm pretty sure we could improve on these things regardin open rewite (like test with multiple java version but I don't have the bandwidth.
Note that all java versions are tested in integration tests
No description provided.