Skip to content

Bring coverage back to 100%#302

Merged
benoit74 merged 1 commit into
mainfrom
test_coverage
May 26, 2026
Merged

Bring coverage back to 100%#302
benoit74 merged 1 commit into
mainfrom
test_coverage

Conversation

@benoit74
Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 commented May 26, 2026

Fix #293

Changes:

  • add no cover pragma in various places:
    • src/zimscraperlib/i18n.py: ... or pass is never executed
    • src/zimscraperlib/zim/indexing.py: impossible to create such a condition under normal lib operation
    • src/zimscraperlib/rewriting/js.py: tricky case, isStrict option is already set in JsRewriter.rewrite based on _detect_strict_mode function which uses the same class hint ; cannot reproduce condition in isolation, not that sure this line is really needed but does not harm tbh
  • add standard test cases for ensure_matches function

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (3adcd39) to head (149333a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
+ Coverage   99.72%   99.96%   +0.23%     
==========================================
  Files          41       41              
  Lines        2545     2542       -3     
  Branches      365      362       -3     
==========================================
+ Hits         2538     2541       +3     
+ Misses          2        0       -2     
+ Partials        5        1       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 self-assigned this May 26, 2026
@benoit74 benoit74 merged commit ff65d77 into main May 26, 2026
9 checks passed
@benoit74 benoit74 deleted the test_coverage branch May 26, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code coverage should be back to 100%

1 participant