Skip to content

Enhance memory management#39

Closed
benoit74 wants to merge 2 commits intomainfrom
async_add_item_for
Closed

Enhance memory management#39
benoit74 wants to merge 2 commits intomainfrom
async_add_item_for

Conversation

@benoit74
Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 commented Mar 3, 2026

Fix #38

This PR introduces two changes to reduce memory consumption:

  • allow to customize number of libzim workers
  • apply backpressure when adding items to the ZIM

@benoit74 benoit74 self-assigned this Mar 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 17.24138% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.30%. Comparing base (327d44d) to head (08ae6c2).
⚠️ Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/maps2zim/processor.py 14.81% 23 Missing ⚠️
scraper/src/maps2zim/entrypoint.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   30.32%   30.30%   -0.02%     
==========================================
  Files          11       11              
  Lines        1052     1069      +17     
  Branches      138      141       +3     
==========================================
+ Hits          319      324       +5     
- Misses        722      734      +12     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74
Copy link
Copy Markdown
Collaborator Author

benoit74 commented Mar 3, 2026

This is dead-locking, let's focus on openzim/python-scraperlib#282 and #40 for the time being

@benoit74
Copy link
Copy Markdown
Collaborator Author

Management of inflight items proved to not be an issue at all, issue was simply redirects handling in libzim

@benoit74 benoit74 closed this Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scraper consumes too much memory, continuously increasing

1 participant