add metadata to title#298
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
+ Coverage 81.52% 82.21% +0.69%
==========================================
Files 58 58
Lines 2571 2694 +123
Branches 259 272 +13
==========================================
+ Hits 2096 2215 +119
- Misses 405 408 +3
- Partials 70 71 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benoit74
left a comment
There was a problem hiding this comment.
Thank you!
First of all, we do not want to ask for metadata when creating a title, they will be populated by first book "entering" the title.
I'm also not convinced by the book warnings property naming ; wondering if issues is not a better naming at this stage, but I'm not totally bought by this.
Finally, I don't think that current UI is correct. I find the fact that we have the capability to "sync" book metadata to title in the book details a bit disturbing. First the "sync" word is confusing because it is hard to guess in which direction the copy will happen. Second the fact this must be done on the book while we edit title metadata is confusing as well. I also don't think that we should group metadata together in a "Metadata" section (aside from Title name, even if it is a metadata). I don't have strong proposition on how to move this forward, but I feel like we do not yet have correct solution.
Unless I missed it, we also miss a maintenance script to populate all title metadata from latest existing book.
Alternative would be to have a boolean column for storing the different issues a book might have. Currently, we have Will these checks have the same impact as |
Alternative would be to move it to the title view but that would require selecting from the list of books available to know which one to update the metadata from. Is that better? |
Sorry, but I don't understand where you mean. There's no Metadata section in the title detail view in the UI. |
|
updated PR description to show the new screenshot of the title edit tab which incorporates buttons to update from the latest book |

Rationale
This PR adds metadata information to CMS titles. This allows having a central store for common metadata for all books belonging to a title.
Changes
warningscolumn for storing warning-level messages to books. These warnings do not prevent a book from being acted upon by shuttle or cms but they prevent the book from being moved to prod even if it's maturity isstableThis closes #292