Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new public endpoint to expose the list of ISO639-3 language codes currently used by books managed in the CMS.
The new endpoint is:
GET /v1/books/languagesIt returns a sorted list of distinct language codes collected from production books only.
Example response:
{ "languages": ["deu", "eng", "fra", "spa"] }What changed
GET /v1/books/languagesunder the existing books APIBook.zim_metadata["Language"]location_kind = "prod"Why
The
Languagemetadata can contain multiple comma-separated ISO639-3 codes. Exposing the normalized set of codes used by production books makes it easier for downstream consumers to know which values they may encounter and validate their support accordingly.Notes
/v1/booksbecause the source of truth isBook.zim_metadataTesting
I verified the change with:
hatch run lint:blackhatch run lint:ruffhatch run check:pyrightFull backend result:
267 passedRelated
Closes #102