Skip to content

nlbwmon: suppress -Werror=discarded-qualifiers#29518

Open
graysky2 wants to merge 1 commit into
openwrt:masterfrom
graysky2:nlbwmon
Open

nlbwmon: suppress -Werror=discarded-qualifiers#29518
graysky2 wants to merge 1 commit into
openwrt:masterfrom
graysky2:nlbwmon

Conversation

@graysky2
Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer: @jow-
(You can find this by checking the history of the package Makefile.)

Description:

GCC 16 tightens enforcement of -Wdiscarded-qualifiers, causing strpbrk() return values assigned to char * locals to hard-error when the input is const char *. Demote to warning until upstream fixes const correctness in config.c.

This is needed for: openwrt/openwrt#23194


🧪 Run Testing Details

  • OpenWrt Version: SNAPSHOT
  • OpenWrt Target/Subtarget: x86/64-glibc
  • OpenWrt Device: Intel N150

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

GCC 16 tightens enforcement of -Wdiscarded-qualifiers, causing strpbrk() return values assigned to char * locals to hard-error when the input is const char *. Demote to warning until upstream fixes const correctness in config.c.

This is needed for: openwrt/openwrt#23194

Signed-off-by: John Audia <therealgraysky@proton.me>
@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented May 23, 2026

Demote to warning until upstream fixes const correctness in config.c.

Is there any upstream issue, which can be tracked?

@graysky2
Copy link
Copy Markdown
Contributor Author

I did not see one nor did I create one since gcc 16 here is not even a finalized PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants